search

duckdblabs / db-benchmark

reproducible benchmark of database-like ops
https://duckdblabs.github.io/db-benchmark/
Mozilla Public License 2.0
143 stars 27 forks source link

`=~` matching in run.sh causes "duckdb-latest" to match "duckdb" #30

Open jangorecki opened 1 year ago

jangorecki commented 1 year ago

Commit https://github.com/duckdblabs/db-benchmark/commit/17d41dbdcf0f758bcab5e7e989247d4194788acc that introduced solution "duckdb-latest" is causing that the following line in run.sh https://github.com/duckdblabs/db-benchmark/blob/17d41dbdcf0f758bcab5e7e989247d4194788acc/run.sh#L66 is matching to duckdb even when duckdb is not being used, but only duckdb-latest. As a result benchmark may fail with the following message:

Error in read.dcf(system.file(package = "duckdb", lib.loc = "./duckdb/r-duckdb",  : 
  cannot open the connection
In addition: Warning message:
In read.dcf(system.file(package = "duckdb", lib.loc = "./duckdb/r-duckdb",  :
  cannot open compressed file '', probable reason 'No such file or directory'
Execution halted

To resolve it we should use more precise operator than =~, till then let's keep this issue open in case someone will be getting such error and trying to search for it.

grantmcdermott commented 8 months ago

Related: Can't we just "drop" the duckdb-latest runs and make this the default for DuckDB?

The duplication is a little confusing and unnecessary since the 0.9 release.

jangorecki commented 8 months ago

I think it is desired for duckdb team to have both version presented to compare performance between stable and devel. I would maybe suggest to trim the name so it fits better on the plots, possibly duckdb-dev