search

duckdblabs / db-benchmark

reproducible benchmark of database-like ops
https://duckdblabs.github.io/db-benchmark/
Mozilla Public License 2.0
136 stars 27 forks source link

fix a typo in setup-juliads.sh #45

Closed sl-solution closed 8 months ago

szarnyasg commented 8 months ago

cc @Tmonster

Tmonster commented 8 months ago

Hi @sl-solution, if I'm not mistaken the current setup scripts for julia have been updated to 1.9.3. Do you mind if I close this PR? https://github.com/duckdblabs/db-benchmark/blob/master/juliadf/setup-juliadf.sh https://github.com/duckdblabs/db-benchmark/blob/master/juliads/setup-juliads.sh

sl-solution commented 8 months ago

Julia is updated to 1.9.3, however, the JULIA_HOME variable is not updated in the following file.

https://github.com/duckdblabs/db-benchmark/blob/master/juliads/setup-juliads.sh

sl-solution commented 8 months ago

has been fixed