search

duckdblabs / db-benchmark

reproducible benchmark of database-like ops
https://duckdblabs.github.io/db-benchmark/
Mozilla Public License 2.0
143 stars 27 forks source link

update Julia codes #7

Closed bkamins closed 1 year ago

bkamins commented 1 year ago

Fixes https://github.com/duckdblabs/db-benchmark/issues/4.

Tmonster commented 1 year ago

seems like getpktmeta in _helpers/helpers.jl throws an error when attempting to get the git hash and version number? I believe it can be changed to 

function getpkgmeta(name::AbstractString)
    fname = joinpath(dirname(Base.active_project()), "Manifest.toml")
    Pkg.TOML.parse(read(fname, String))["deps"][name][1]
end;
bkamins commented 1 year ago

Yes. This is a bit hacky, but let us leave as is. I updated the PR.

Tmonster commented 1 year ago

Looks good to me! Thank you for opening a PR 👍