[Bug] Dialog Fragments do not follow Dark theme

[4shutosh]

Describe the bug

DialogFragments (example: from settings activity) do not follow the theming options of the app

How to Reproduce

Open Settings Screen:

• Click on Fire Button Animation (Dark theme being enabled)
• The dialog does not follow the dark theme

Expected behavior

• The dialog fragments should follow the app theming options

Environment

- DDG App Version: develop branch
- Device: Pixel 4XL
- OS: Android 11

[4shutosh]

I would like to work on this issue. @malmstein Can you please assign this to me?

[malmstein]

Thanks for filing this one @4shutosh!

I appreciate your desire to help, however we'll take this one internally. The main reason being, we need input from the Design team to decide colors and background and an internal review from different stakeholders. It would take too long to go back and forth.

[4shutosh]

Got it @malmstein Thank you for the explanation.

I'll try to look into some issues which won't require an internal process for further continuity :) Also please feel free to assign me any issue/task of your choice, I'll be more than happy to work on it.

[cmonfortep]

This has been already fixed and published in our latest release 5.95.0

[4shutosh]

I've installed 5.95.0 from google playstore and this does not work foe me.

[4shutosh]

@cmonfortep Can you please corroborate? ( Device: Pixel 5, Android 11 )

[cmonfortep]

Sorry, you are right! Thanks for the screenshot. We fixed the confirmation dialog to clear all data.

I'm reopening the issue.

[4shutosh]

Sure 🙌🏻 Can I please work on this issue 😄 ?

[cmonfortep]

@4shutosh 👍👍