search

duckduckgo / Android

DuckDuckGo Android App
https://play.google.com/store/apps/details?id=com.duckduckgo.mobile.android
Apache License 2.0
3.81k stars 902 forks source link

Add support for Android Adaptive Icons #305

Closed dstaley closed 5 years ago

dstaley commented 6 years ago

With the release of Android Oreo, support was added for adaptive icons that accommodate various shapes. For example, Pixel devices use a circular mask while Samsung devices use a squircle.

Adding support for adaptive icons to this project would be fairly simple since the icon would basically be Dax over a red background.

I mocked up what this could look like: image

You can keep a specific round icon if you want to retain the white circle currently present, but I think it still looks good without it (and matches a few other instances of the Dax logo).

I'd be happy to send in a PR with updated resources to add this functionality if this is something you'd like to support. Currently, if a user is using an Android Oreo devices with a launcher that uses a mask other than the circular mask, the circular icon gets displayed inside a white frame. Here's an example of this: image

kochie commented 5 years ago

Bumping this issue. It would be cool to have an adaptive icon, it makes the app look modern on new Android versions.

JulienGenoud commented 5 years ago

@subsymbolic do you have any plan to do it? Can i do a PR ?

subsymbolic commented 5 years ago

Hey @dstaley and @JulienGenoud thanks for the offer to do this, that's awesome. I think our designers will want to cover it, I'll check-in with them and report back.

subsymbolic commented 5 years ago

I've checked with our designers and they are on the case. We will have adaptive icon support out soon.

subsymbolic commented 5 years ago

The adaptive icon is now PR https://github.com/duckduckgo/Android/pull/612 and will released in the next 1-2 weeks. Thanks for logging this issue and suggesting the change @dstaley.