[Bug] Cannot download PDFs from GitHub

duckduckgo / Android

DuckDuckGo Android App

https://play.google.com/store/apps/details?id=com.duckduckgo.mobile.android

Apache License 2.0

3.82k stars 901 forks source link

[Bug] Cannot download PDFs from GitHub #3645

Open bluecmd opened 1 year ago

bluecmd commented 1 year ago

Describe the bug

Hello,

I'm unable to download PDF files from GitHub when using the DDG app specifically.

How to Reproduce

Navigate to any PDF hosted on GitHub. E.g. https://github.com/mozilla/pdf.js/blob/master/test/pdfs/ArabicCIDTrueType.pdf
- Press the "..." next to the branch name.
- Press "Download"
- Observe that nothing happens

If you do the same steps in Firefox on Android the PDF is downloaded.

Expected behavior

The PDF file is downloaded

Environment

- DDG App Version: 5.175.1
- Device: Pixel 6 Pro
- OS: Android 14

github-actions[bot] commented 1 year ago

Thank you for opening an Issue in our Repository. The issue has been forwarded to the team and we'll follow up as soon as we have time to investigate. As stated in our Contribution Guidelines, requests for feedback should be addressed via the Feedback section in the Android app.

Rajkdea123 commented 1 year ago

Can i resolve this issue?

bluecmd commented 1 year ago

Can i resolve this issue?

I still can't download the linked PDF in the latest DDG Browser, so I would say no. Are you able to download it using the reproduce instructions?

Rajkdea123 commented 1 year ago

Ok, I'll try,I didn't do it yet

On Sat, Oct 21, 2023, 11:07 Christian Svensson @.***> wrote:

Can i resolve this issue?

I still can't download the linked PDF in the latest DDG Browser, so I would say no. Are you able to download it using the reproduce instructions?

— Reply to this email directly, view it on GitHub https://github.com/duckduckgo/Android/issues/3645#issuecomment-1773678641, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXQGAVXWDKUVBKV4MJIWKZ3YANNSJAVCNFSM6AAAAAA53NW5UWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZTGY3TQNRUGE . You are receiving this because you commented.Message ID: @.***>

woheller69 commented 10 months ago

In my view this is due to GitHub's content security policy. They do not want us to inject code to retrieve the pdf in the blob. Doesn't work with my FREE Bowser either.

anikiki commented 2 months ago

This is solved in 5.209.2.

woheller69 commented 2 months ago

This is solved in 5.209.2.

No, it is not solved. Still nothing happens when clicking "Download" as described above

anikiki commented 1 month ago

@woheller69 Due to WebView constraints, this works only if your installed System WebView version (Chrome version) is above "126.0.6478.40". Right now, the latest one is "128.0.6613.127".