Add custom tab navigation - Githubissues

duckduckgo / Android

DuckDuckGo Android App

https://play.google.com/store/apps/details?id=com.duckduckgo.mobile.android

Apache License 2.0

3.59k stars 873 forks source link

Add custom tab navigation #4521

Closed joshliebe closed 2 weeks ago

joshliebe commented 3 weeks ago

Task/Issue URL: https://app.asana.com/0/488551667048375/1207186871481910/f

Description

Adds navigation in custom tabs via gestures or the UI.

Steps to test this PR

[ ] Make the DuckDuckGo debug app the default browser
[ ] Open Gmail
[ ] Click on a link in one of the emails
[ ] Verify that navigation inside the custom tab works as expected

(You can check that it has opened in a custom tab by clicking the 3 dots and in the menu it will say "Running in DuckDuckGo")

UI changes

Forward nav is now enabled: combined

joshliebe commented 3 weeks ago

#4535
#4532
#4521 👈
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joshliebe and the rest of your teammates on Graphite