search

duckduckgo / Android

DuckDuckGo Android App
https://play.google.com/store/apps/details?id=com.duckduckgo.mobile.android
Apache License 2.0
3.62k stars 872 forks source link

New Tab: Extract Legacy Page #4567

Open malmstein opened 1 month ago

malmstein commented 1 month ago

Task/Issue URL: https://app.asana.com/0/72649045549333/1207111525225329

Description

This PR extracts the New Tab Page logic outside of BTF. This is necessary for future work done to NTP.

Steps to test this PR

Smoke tests

malmstein commented 1 month ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @malmstein and the rest of your teammates on Graphite Graphite

malmstein commented 3 weeks ago

@cmonfortep this is ready for review. Tests are fixed further up the stack.

cmonfortep commented 2 weeks ago

FYI: I had to fix some compiling issue in this branch to run it. Please check changes against develop in case something missing when restacking.

malmstein commented 1 week ago

@cmonfortep I’ve removed the Survey and Home CTA as per https://github.com/duckduckgo/Android/pull/4646. When it’s all merged I’ll rebase here and ping you for more.