Allow bookmarks to be shown in top hits - Githubissues

duckduckgo / Android

DuckDuckGo Android App

https://play.google.com/store/apps/details?id=com.duckduckgo.mobile.android

Apache License 2.0

3.62k stars 872 forks source link

Allow bookmarks to be shown in top hits #4572

Closed CrisBarreiro closed 1 month ago

CrisBarreiro commented 1 month ago

Task/Issue URL: https://app.asana.com/0/0/1207300113417901/f

Description

Steps to test this PR

Feature 1

[ ] Do a clean install
[ ] Visit wikipedia.org
[ ] Save it as bookmark
[ ] Visit wikimedia.org
[ ] Save it as favorite
[ ] Use the fire button
[ ] Type wiki
[ ] Check wikimedia (favorite) is the first result in top hits, and wikipedia (bookmark) is the second

Feature 1

[ ] Do a clean install
[ ] Visit wikipedia.org
[ ] Save it as bookmark
[ ] Type wiki
[ ] Check wikipedia is shown in top hits

UI changes

Before	After
!(Upload before screenshot)	(Upload after screenshot)

CrisBarreiro commented 1 month ago

[!WARNING] This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite. Learn more

#4572 👈
#4332 : 3 other dependent PRs (#4341 , #4450 , #4599 )
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CrisBarreiro and the rest of your teammates on Graphite