Design improvements - Githubissues

duckduckgo / Android

DuckDuckGo Android App

https://play.google.com/store/apps/details?id=com.duckduckgo.mobile.android

Apache License 2.0

3.62k stars 872 forks source link

Design improvements #4574

Closed CrisBarreiro closed 4 weeks ago

CrisBarreiro commented 1 month ago

Task/Issue URL: https://app.asana.com/0/0/1207259212212441/f

Steps to test this PR

Feature 1

[ ] Write a random query like "asdasdhauhqwufdrgqfiu"
[ ] Check there's only one result displayed and that it contains the same query
[ ] Check the autocomplete list takes all available vertical space so the site underneath is not visible

UI changes

Before	After
!(Upload before screenshot)	(Upload after screenshot)

CrisBarreiro commented 1 month ago

#4593
#4574 👈
#4559
#4545
#4495
#4451
#4450
#4332 : 3 other dependent PRs (#4341 , #4572 , #4599 )
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CrisBarreiro and the rest of your teammates on Graphite

CrisBarreiro commented 4 weeks ago

LGTM

Feel free to re-request another review if you introduce more changes, but LGTM in the current status.

Note: when changing between a real suggestion and the default view, I see text jumping a bit, probably there's a size/margin not aligned.

Thanks! Regarding the note, I'm aware of it, I'll address it tomorrow, as well as some other minor issues that Sveta reported today