Add additional intent flags for external apps - Githubissues

duckduckgo / Android

DuckDuckGo Android App

https://play.google.com/store/apps/details?id=com.duckduckgo.mobile.android

Apache License 2.0

3.62k stars 872 forks source link

Add additional intent flags for external apps #4578

Closed joshliebe closed 1 month ago

joshliebe commented 1 month ago

Task/Issue URL: https://app.asana.com/0/488551667048375/1207383486029583/f

Description

To fix issues when logging into Ticketmaster with Custom Tabs, these flags have been added when opening external apps:
- Intent.CATEGORY_BROWSABLE
- Intent.FLAG_ACTIVITY_NEW_TASK | Intent.FLAG_ACTIVITY_CLEAR_TOP
Also adds a safeguard to disable the new flags if needed.

Config PR: https://github.com/duckduckgo/privacy-configuration/pull/2093

Steps to test this PR

[x] Point at the JSON blob linked in the task
[x] Install the Ticketmaster US app
[x] Make DDG the default browser
[x] Sign in using the Ticketmaster app
[x] Verify that the sign-in form opens in a DDG custom tab
[x] Sign in and tap “Open” on the dialog
[x] Verify that Ticketmaster is not opened
[x] Enable the externalAppIntentFlags feature in the JSON blob
[x] Relaunch DDG
[x] Sign in using the Ticketmaster app
[x] Verify that the sign-in form opens in a DDG custom tab
[x] Sign in and tap “Open in app” on the dialog
[x] Verify that Ticketmaster is opened and signed-in

joshliebe commented 1 month ago

#4578 👈
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joshliebe and the rest of your teammates on Graphite