Onboarding end Dax dialog - Githubissues

duckduckgo / Android

DuckDuckGo Android App

https://play.google.com/store/apps/details?id=com.duckduckgo.mobile.android

Apache License 2.0

3.62k stars 872 forks source link

Onboarding end Dax dialog #4603

Closed nalcalag closed 2 weeks ago

nalcalag commented 3 weeks ago

Task/Issue URL: https://app.asana.com/0/1201807753394693/1207353075657638/f

Description

Add new onboarding End dialog when the onboarding flow finishes without the fire button animation

Steps to test this PR

[x] Fresh install
[x] Go to the browser
[x] Select a search suggestion
[x] Tap on 'Got it!' button in the onboarding dialog
[x] Select a site suggestion
[x] Tap on 'Got It!' button in the onboarding dialog
[x] Fire dialog should appear
[x] Navigate away tapping on a site link or typing something in the search bar
[x] Check new End dialog will appear ('You've got this!')
[x] Open a new tap (without dismissing the dialog)
[x] Check End dialog won't appear in the new tab page

UI changes

Light	Dark

nalcalag commented 3 weeks ago

#4603 👈
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @nalcalag and the rest of your teammates on Graphite