Remove new background from New Tab Page - Githubissues

duckduckgo / Android

DuckDuckGo Android App

https://play.google.com/store/apps/details?id=com.duckduckgo.mobile.android

Apache License 2.0

3.63k stars 871 forks source link

Remove new background from New Tab Page #4632

Closed nalcalag closed 2 weeks ago

nalcalag commented 2 weeks ago

Task/Issue URL: https://app.asana.com/0/1201807753394693/1207526605452078/f

Description

Remove new browser background in new tab page. Just keeping it for onboarding dialogs

Steps to test this PR

Onboarding dialogs with new background set

[x] Fresh install
[x] Go to browser
[x] Check clouds background is set and Search suggestions dialog is displayed
[x] Tap on a search suggestion
[x] SERP onboarding dialog will appear on the top of the site
[x] Open a new tab
[x] Check clouds background is set and Site suggestions dialog is displayed
[x] Tap on a site suggestion
[x] Trackers blocked dialog will appear on top of the site
[x] Dismiss dialog tapping on the CTA button
[x] Open a new tab
[x] End dialog will display with clouds dialog
[x] Perform a search or visit a site
[x] Open a new tab
[x] New tab page won't have hte cloud background anymore

New Tab page with favorites

[x] Dax Logo is displayed in New Tab Page with no background
[x] Go to a site
[x] Add it to favorites
[x] Open a new tab
[x] Check favorite is added to new tab page
[x] Check new tab page doesn't have set any background

UI changes

Before	After

nalcalag commented 2 weeks ago

#4632 👈
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @nalcalag and the rest of your teammates on Graphite