search

duckduckgo / Android

DuckDuckGo Android App
https://play.google.com/store/apps/details?id=com.duckduckgo.mobile.android
Apache License 2.0
3.63k stars 871 forks source link

[Bug] Favourited Bookmarklets Search Instead of Running #4638

Closed Hamsteroonie closed 2 weeks ago

Hamsteroonie commented 2 weeks ago

Describe the bug

When running a bookmarklet let that is favourited, it will search the contents of the bookmarklet instead of running it.

How to Reproduce

  1. Bookmark a site
  2. Click 'Edit Bookmark'
  3. Add to favourites and change the URL to a bookmarklet (e. g. 'javascript:alert("example")' )
  4. Open any website
  5. Tap on the search bar
  6. Click on the bookmarklet

https://github.com/duckduckgo/Android/assets/144549336/941517f5-2562-4c62-8fcf-614fc489392c

Expected behavior

It should run the bookmarklet in the same way that it runs when you type the name of the bookmarklet into the search bar and press the autocomplete for that bookmarklet.

Environment

- DDG App Version: 5.203.1
- Device: Doogee T20 Mini
- OS: Android 13
github-actions[bot] commented 2 weeks ago

Thank you for opening an Issue in our Repository. The issue has been forwarded to the team and we'll follow up as soon as we have time to investigate. As stated in our Contribution Guidelines, requests for feedback should be addressed via the Feedback section in the Android app.

cmonfortep commented 2 weeks ago

Thanks for sharing. Currently we don't officially support bookmarklets on mobile, but we can take a look an see if there's any quick win we can safely introduce.