Closed malmstein closed 1 week ago
This stack of pull requests is managed by Graphite. Learn more about stacking.
Join @malmstein and the rest of your teammates on Graphite
@malmstein if I rotate the screen following the steps to test, it crashes.
When fun renderHomeCta()
is called after onConfigurationChanged()
, we get the exception lateinit property ctaBottomSheet has not been initialised
.
Ping me if you need anything.
@malmstein I tested this and works as expected 👍 However, I have a couple of concerns with the change:
Cta.kt
class instead of directly from the BrowserTabFragment
for consistency and to extract code from the Fragment. We can create a new interface BottomSheetCta
which would have buildCta()
and return the instance of the PromoBottomSheetDialog. Then make HomePanelCta
to implement this new interface instead ViewCta
. (Just an idea)I'll include this comment in Asana too so we can discuss it there.
Thanks @nalcalag !
Task/Issue URL: https://app.asana.com/0/1174433894299346/1207561426611562/f
Description
Migrates HomeCTA to use PromoBottomSheet We are also removing all the code to display Surveys in that CTA
Steps to test this PR
Widget CTA Orientation
Widget CTA Logic
Survey CTA Removal