duckduckgo / Android

DuckDuckGo Android App
https://play.google.com/store/apps/details?id=com.duckduckgo.mobile.android
Apache License 2.0
3.77k stars 892 forks source link

Disable Force Dark Mode when WebView version doesn't support it #4653

Closed malmstein closed 3 months ago

malmstein commented 3 months ago

Task/Issue URL: https://app.asana.com/0/1157893581871903/1207572180893002/f

Description

We enabled ✓ Android: Force dark mode in sites that don’t support it This was causing the app crash in webview versions that didn’t support it. Fixed in✓ setAlgorithmicDarkeningAllowed crashing the app After this fix, devices with webview versions that don’t support algorithmic darkening won’t see the feature.

This PR removes this option in devices that don’t support it

Steps to test this PR

WebView not supported

WebView supported

malmstein commented 3 months ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @malmstein and the rest of your teammates on Graphite Graphite

malmstein commented 3 months ago

@CrisBarreiro good catch, I’ve updated the description now.

malmstein commented 3 months ago

Thanks @CrisBarreiro !