Android: Move custom tabs to its own module

duckduckgo / Android

DuckDuckGo Android App

https://play.google.com/store/apps/details?id=com.duckduckgo.mobile.android

Apache License 2.0

3.62k stars 870 forks source link

Android: Move custom tabs to its own module #4666

Closed anikiki closed 1 week ago

anikiki commented 1 week ago

Task/Issue URL: https://app.asana.com/0/1200581511062568/1207177220363583/f

Description

Transferred the Custom Tabs code to a separate module.

Steps to test this PR

Smoke testing.

[x] Install from this branch. Set DuckDuckGo as default browser.
[x] Use various apps to open the DDG Custom Tab (Gmail / Twitter / etc).

NO UI changes

anikiki commented 1 week ago

#4666 👈
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @anikiki and the rest of your teammates on Graphite

CDRussell commented 1 week ago

Functionally, working as expected. Heads up there's a merge conflict to resolve.

Just one (blocking) question about where the pixels live; right now the app module is touching the impl of the new module which seems wrong.

anikiki commented 1 week ago

Functionally, working as expected. Heads up there's a merge conflict to resolve.

Just one (blocking) question about where the pixels live; right now the app module is touching the impl of the new module which seems wrong.

Thanks :+1: I moved the CustomTabPixelNames back to app and solved the conflicts.