CTAs should be dismissable when other CTAs are also visible

duckduckgo / Android

DuckDuckGo Android App

https://play.google.com/store/apps/details?id=com.duckduckgo.mobile.android

Apache License 2.0

3.77k stars 892 forks source link

CTAs should be dismissable when other CTAs are also visible #4694

Closed malmstein closed 3 months ago

malmstein commented 3 months ago

Task/Issue URL: https://app.asana.com/0/1157893581871903/1207661039495530/f

Description

HomePanel CTA is not dismissed in RMF is present.

Steps to test this PR

See https://app.asana.com/0/1157893581871903/1207661039495530/f

malmstein commented 3 months ago

#4694 👈
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @malmstein and the rest of your teammates on Graphite

malmstein commented 3 months ago

@cmonfortep We shouldn’t rely on currentCtaViewState to see if there’s a visible CTA or not. This is a mutable class that we override. The correct way of doing it is to pass the cta from the click listener itself. Same thing happens with RMF.