duckduckgo / Android

DuckDuckGo Android App
https://play.google.com/store/apps/details?id=com.duckduckgo.mobile.android
Apache License 2.0
3.62k stars 870 forks source link

Remove incorrect verification #4695

Closed karlenDimla closed 2 days ago

karlenDimla commented 2 days ago

Task/Issue URL: https://app.asana.com/0/488551667048375/1207658463781438/f

Description

Replace verification with try catch instead. The current solution incorrectly fails the check even if the value is of the correct type.

Instead of verifying the values, we just try catch it. If an exception occurs, we don’t match it.

Steps to test this PR

Tests pass + QA optional

karlenDimla commented 2 days ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @karlenDimla and the rest of your teammates on Graphite Graphite