duckduckgo / Android

DuckDuckGo Android App
https://play.google.com/store/apps/details?id=com.duckduckgo.mobile.android
Apache License 2.0
3.85k stars 909 forks source link

Fix UI flash after fire button action #4910

Closed mikescamell closed 2 months ago

mikescamell commented 3 months ago

Task/Issue URL: https://app.asana.com/0/488551667048375/1207509101295228/f

Description

Steps to test this PR

UI Flash

Worth noting that I seemed to see the website flash after the first clear data attempt from app launch. In subsequent clear data attempts I did not see the website.

Edge to Edge Fire Animation

UI changes

Fixing UI Flash

Before After
(API 34 Before) (API 34 After)

Edge to Edge Fire animation

Before After
(API 26 Before) (API 26)
(API 27)
(API 28)
(API 29)
(API 29 Dark)
(OnePlus 30 Light Before) (OnePlus 30 Light)
(OnePlus 30 Dark Before) (OnePlus 30 Dark)
(API 31)
(API 32 Dark)
(API 33)
(API 33 Light)
(API 34 No Animation Selected)
(API 34 Airstream)
(API 34 Three Button Before) (API 34 Three Button)
(API 34 Dark Three Button)
(API 34 Dark Before) (API 34 Dark)
(API 34 Light Before) (API 34 Light)
mikescamell commented 3 months ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @mikescamell and the rest of your teammates on Graphite Graphite