Update ESLint configuration

duckduckgo / autoconsent

Mozilla Public License 2.0

76 stars 20 forks source link

Update ESLint configuration #473

Open seia-soto opened 2 months ago

seia-soto commented 2 months ago

This PR:

migrates eslint configuration to flat config respecting existing setup
imports recommended default of prettier and typescript linter configs
adds missing types for some files (replaces any)

There's a huge change in lib/consentomatic/tools.ts to support types properly. However, I could not fill all types up in consentomatic part as I lack some knowledge about the library internals. I added an eslint exception for those parts at this time and expect to fix in the future.

muodov commented 1 month ago

Hey @seia-soto, thanks for this contribution! The current code style could use some improvement indeed. However, if we do this, we would like to make it consistent with the other DDG repos. This has actually been in our backlog for a while, but we couldn't prioritise it yet.

The proposed changes here don't match the existing configs in our extension and content-scope-scripts.

Does this PR block anything on your side? If yes, let me know and we can figure out a compromise. If you just want to help, we would be super grateful if you match the style config to one of the other DDG repos mentioned above. 🙏🏼

seia-soto commented 1 month ago

Hi @muodov ,

It's not blocking anything on my side hopefully. I don't contribute here daily but I always find that automatic checks and linting are really helpful.

I don't want to make a change that is not necessary but are you considering to migrate to eslint flat config? As I know, standardjs is not exporting the flat config yet (https://github.com/eslint/eslint/issues/18093) and instead, they have a successor to it called neostandard as I know.