search

duckduckgo / community-platform-static

Shared static files of the community platform and related sites
4 stars 4 forks source link

community-platform CSS question / deploy and integration question. #3

Open jbarrett opened 9 years ago

jbarrett commented 9 years ago
Should all of community-platform's CSS be in this project?

Currently, there is CSS in community-platform-static (cool) but also spread across community-platform in various places:

Styles in perl

Styles in templates

Styles in files

So, while individual "applications" in the duck.co space will have their own style requirements, I'm thinking anything that's a "main site" style should be here.

This brings me onto the next question:

Should this project's maintenance / release be off DuckPAN?

Using a CPAN to distribute CSS strikes me as A Bad Thing, if only because our nginx config winds up relying on the currently deployed Perl version...

Also, integrating with this project for development is a bit grey - it's not immediately obvious the best way to do it.

I'm thinking these files should be part of the DDGC package and that they should exist in the development community-platform insance. Git submodules are kind of bad, but might work. Anything. Bound mount. Symlink. cp. OK, not cp.

Something that makes community-platform-static's existence more obvious and easier to work with.

//cc @sdougbrown @thm @zekiel @russellholt @MariagraziaAlastra @jdorweiler

jbarrett commented 9 years ago

Looks like community-platform depends on App::DuckPAN just to install DDGC::Static

zekiel commented 9 years ago

//reference issue #654

russellholt commented 9 years ago

I think you want CSS to be accessible to front-end developers in a standard way. We're starting down the path of implementing scss the way it's done for duckduckgo.com, as part of the redesign, and to share a lot of commonalities with it. Is there a reason we should not do that? The css would be be almost completely overhauled as part of this process, I would think.

jbarrett commented 9 years ago

@russellholt What's the "standard way" here? Is it packaging and distribution or "The css lives at this URL and provides this"?

russellholt commented 9 years ago

That it lives in .css files in a centralized directory, or that they work within a build system like sass/scss. but again, in some central place using a common method of building.

jbarrett commented 9 years ago

Yup, central good.

We should probably deprecate this project. I don't think the CSS needs to be portable to projects other than community-platform.

russellholt commented 9 years ago

agree