Filter out categories with no related helps

[jbarrett]

Description :

Do not show empty help categories on help pages

Reviewer notes :

Yes, this should be done in the query but this isn't significantly slower and allows me to not have to think about it.

• Removing or changing the cache_for value to 0 on line 17 should make testing this easier
• Using the help editor in /admin/help, remove all help articles from a given category
• This category should no longer be visible on /help or the side menu on help pages
• Re-adding articles to this category should show them again on these pages

References issues / PRs:

#

Who should be informed of this change?

@tagawa

Does this change have significant privacy, security, performance or deployment implications?

Nah - grepping across a handful of rows is fast enough.

Checklist :

• [ ] Back end tests (perl, scripts)
• [ ] Front end tests (js, integration)
• Browser verification
  • [ ] IE
  • [ ] Chrome
  • [ ] Firefox
  • [ ] Safari
  • [ ] Opera
• Mobile verification
  • [ ] iOS
  • [ ] Android

[MariagraziaAlastra]

Thanks! Looks good, everything working as expected :+1: