duckduckgo / community-platform

DuckDuckGo Community Platform
https://duck.co/
Other
457 stars 128 forks source link

Retire code relying on beta server #1512

Closed MariagraziaAlastra closed 6 years ago

MariagraziaAlastra commented 6 years ago
Description :

change JSON API URL to the new one, retire beta installation code on the backend and frontend.

Who should be informed of this change?

@kablamo @jkv @moollaza @jdorweiler @tagawa

Does this change have significant privacy, security, performance or deployment implications?

We'll test this for a day and assuming nothing unexpected breaks, we'll keep the change. This might make the dev pipeline inaccurate going forward (especially the "Testing" column) and might also break the "generate screenshot" button in the single IA Pages.

Steps to test

  1. Populate the IA DB if not done already by running script/ddgc_populate_ia_dev.pl
  2. run grunt
  3. script/ddgc_dev_server.sh
  4. On the instance, verify the following paths: /ia (shows list of IAs), /ia/dev/pipeline (Dev Pipeline), single IA Pages - they should all be populated and looking like in prod
  5. Log in as admin (TestOne) and go to single IA Page live and also in development - there should be no beta install button in the sidebar
  6. Click on the name and not on the anchor link for some IAs in the Dev Pipeline. A sideview should open. No "install on beta" button should be there
  7. Editing and committing should still work for single IA Pages
  8. In case something's wrong, the relevant JSON endpoints are ia/json and ia/dev/pipeline/json
Checklist :
jbarrett commented 6 years ago

Functionally, this seems good.

Code wise, well it's got just about everything I like to see... deleted

I just have one question: The production JSON on S3 is drawn exclusively from the database and relies on nothing from beta - is this correct?

Thanks!

MariagraziaAlastra commented 6 years ago

Yeah that's correct, thanks @jbarrett!