search

duckduckgo / community-platform

DuckDuckGo Community Platform
https://duck.co/
Other
456 stars 128 forks source link

Redirect is removing anchor tags from URL's? #329

Closed moollaza closed 9 years ago

moollaza commented 9 years ago

In the docs, we link to the DuckPAN repo and the URL's are set to target anchors on the DuckPAN README page. @zekiel noticed that the after clicking the link you just end up on the DuckPAN repo page, but the anchor is no longer in the URL. I believe our redirect is removing the anchors from the URL's -- which probably isn't expected?

The broken links can be found her: https://duck.co/duckduckhack/setup_dev_environment#before-you-start

Here's a link going through the redirect which will fail to include the anchor: https://duck.co/redir/?u=https://github.com/duckduckgo/p5-app-duckpan#installing-duckpan-locally

//cc @jbarrett @zekiel

jbarrett commented 9 years ago

Dang, I knew there was a reason I should have left url encoding in place.

jbarrett commented 9 years ago

OK, this should be resolved, can you confirm @moollaza? Thanks.

moollaza commented 9 years ago

LGTM :+1: Link are working in the docs as expected