duckduckgo / duckduckgo-documentation

Deprecated - OLD - See Below
Other
44 stars 60 forks source link

Arrow keys broken in Cheat sheet doc #293

Closed iambibhas closed 9 years ago

iambibhas commented 9 years ago

Although the arrows appear correctly here, this is how they appear in the generated doc -

selection_063

moollaza commented 9 years ago

@iambibhas thanks for noticing! I've pushed a fix. Should be live soon:

creating_cheat_sheets___goodie___duckduckhack

moollaza commented 9 years ago

/cc @talsraviv looks like we can't put ASCII/Unicode chars into the docs as plaintet. :disappointed:

We'll neet to use the HTML Entities (e.g. ←) where applicable. Unfortunately we can't put any in code blocks though as the won't get rendered as HTML. Hence, I used bolding at the bottom of the pic above instead of an inline code-block.

iambibhas commented 9 years ago

@moollaza the doc generator doesn't support unicode characters?

moollaza commented 9 years ago

@iambibhas now that I think about it a little more, it's likely a bug in our parsing code, not Markdent. Looking into it now

moollaza commented 9 years ago

After quite some time fighting with Perl and UTF8 encodings/decodings I believe I've now fixed our documentation generator's handling of UTF8 in the docs.

Will revert this fix later to verify, once my PR has been merged.

iambibhas commented 9 years ago

:+1: