search

duckduckgo / duckduckgo-documentation

Deprecated - OLD - See Below
Other
44 stars 60 forks source link

Improve Cheat Sheets Goodie documentation #335

Closed nemeth closed 8 years ago

nemeth commented 8 years ago

I ran into a problem with uppercase letters within cheat sheet aliases. Since the first suggested alias ('LOTR') is in uppercase, I tried to add some notice to the doc to avoid such a situation. The other option is to use lc in getAliases to lowercase all alias and let developers use capital letters in the .json files.

moollaza commented 8 years ago

@nemeth apologies for the confusion, and thank you very much for submitting an update. I think both suggestions are great. We should ask users to ensure they use lowecase aliases, but there's no harm in forcing the alias to lowercase as well to prevent potential bugs.

These changes LGTM :+1:

talsraviv commented 8 years ago

@nemeth good stuff - thank you