search

duckduckgo / duckduckgo-locales

Translation files for duckduckgo.com
https://duckduckgo.com/
96 stars 165 forks source link

shopping: add title for Shopping Vertical filter modal #728

Closed sjbarag closed 2 weeks ago

sjbarag commented 3 weeks ago

We're running an experiment with filters in the Shopping Vertical^1 that places those filters in a modal. By design's request, we should use the same string for both the modal title and the button label. Add that label to the translation .po files.

Note: This PR seems to include a few unrelated changes, but I'm not sure why.

GioSensation commented 2 weeks ago

@sjbarag Is this good to merge? It includes a highly visible fix we updated in Smartling and got pushed to the only open branch. If this is not good to merge, please let me know and I will include that fix separately.

sjbarag commented 2 weeks ago

Ah, I didn't realize this wasn't limited to my Smartling job. No concerns from me.