duckduckgo / duckduckgo-privacy-extension

DuckDuckGo Privacy Essentials browser extension for Firefox, Chrome.
https://duckduckgo.com/app
Apache License 2.0
1.21k stars 242 forks source link

Remove build tooling for static declarativeNetRequest rulesets #2505

Closed kzar closed 2 months ago

kzar commented 2 months ago

Anticipating hitting Chrome's limit of 5,000 dynamic declarativeNetRequest rules[1], we begun work[2] to transition tracker blocking to use a static declarativeNetRequest ruleset. That work got put on hold, and since then Google have relaxed the dynamic rule limit to around 30,000[3] (though note that the limits are even more complex now, with a distinction between "safe" vs "unsafe" rules).

The new dynamic rule limit should be plenty for our needs in the foreseeable future. Let's remove the code to generate static declarativeNetRequest rulesets at build time.

1 - https://developer.chrome.com/docs/extensions/reference/declarativeNetRequest/#property-MAX_NUMBER_OF_DYNAMIC_AND_SESSION_RULES 2 - https://github.com/duckduckgo/duckduckgo-privacy-extension/commit/d3b3827c731628d79bbbf9c6cfa0ccab3bde36db 3 - https://issues.chromium.org/issues/40282671

Reviewer: @sammacbeth