include same-entity none-trackers - Githubissues

duckduckgo / duckduckgo-privacy-extension

DuckDuckGo Privacy Essentials browser extension for Firefox, Chrome.

https://duckduckgo.com/app

Apache License 2.0

1.21k stars 242 forks source link

include same-entity none-trackers #2553

Closed shakyShane closed 5 days ago

shakyShane commented 2 weeks ago

Reviewer: @sammacbeth

https://app.asana.com/0/1201141132935289/1207506709815881/f

Description:

Other platforms keep track of 3rd party requests, even when they are the same entity. See: https://app.asana.com/0/1201141132935289/1207506709815881/f

Steps to test this PR:

Visit Microsoft.com
Open the Privacy Dashboard
You should see requests in the '3rd party' section from domains like live.com or other Microsoft properties
- these do not currently show.

Automated tests:

[ ] Unit tests
[ ] Integration tests

Reviewer Checklist:

[ ] Ensure the PR solves the problem
[ ] Review every line of code
[ ] Ensure the PR does no harm by testing the changes thoroughly
[ ] Get help if you're uncomfortable with any of the above!
[ ] Determine if there are any quick wins that improve the implementation

PR Author Checklist:

[ ] Get advice or leverage existing code
[ ] Agree on technical approach with reviewer (if the changes are nuanced)
[ ] Ensure that there is a testing strategy (and documented non-automated tests)
[ ] Ensure there is a documented monitoring strategy (if necessary)
[ ] Consider systems implications

To see the specific tasks where the Asana app for GitHub is being used, see below:
- https://app.asana.com/0/0/1207550488916516

shakyShane commented 2 weeks ago

#2553 👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @shakyShane and the rest of your teammates on Graphite