Update jasmine dependency to 5.2.0 - Githubissues

duckduckgo / duckduckgo-privacy-extension

DuckDuckGo Privacy Essentials browser extension for Firefox, Chrome.

https://duckduckgo.com/app

Apache License 2.0

1.27k stars 245 forks source link

Update jasmine dependency to 5.2.0 #2613

Closed kzar closed 3 months ago

kzar commented 3 months ago

Some small tweaks to the unit tests were required to get them passing again.

Reviewer: @jonathanKingston

Description:

Steps to test this PR:

Automated tests:

[ ] Unit tests
[ ] Integration tests

Reviewer Checklist:

[ ] Ensure the PR solves the problem
[ ] Review every line of code
[ ] Ensure the PR does no harm by testing the changes thoroughly
[ ] Get help if you're uncomfortable with any of the above!
[ ] Determine if there are any quick wins that improve the implementation

PR Author Checklist:

[ ] Get advice or leverage existing code
[ ] Agree on technical approach with reviewer (if the changes are nuanced)
[ ] Ensure that there is a testing strategy (and documented non-automated tests)
[ ] Ensure there is a documented monitoring strategy (if necessary)
[ ] Consider systems implications