search

duckduckgo / duckduckgo-privacy-extension

DuckDuckGo Privacy Essentials browser extension for Firefox, Chrome.
https://duckduckgo.com/app
Apache License 2.0
1.25k stars 243 forks source link

Autofill Email Protection not working #876

Open noahmaranesi opened 3 years ago

noahmaranesi commented 3 years ago

Description

I've tried numerous times over the past few months to get Email Protection Autofill to work. I have my own "@duck.com" address and the aliases are working fine. I am however unable to do them in-line as advertised for on websites.

Steps to Reproduce

  1. Install "DuckDuckGo Privacy Essentials" for Firefox
  2. Enable the plugin
  3. Right-click in a field and click "Use Duck Address"

Expected behaviour:

Actual behaviour:

Versions

Additional information: I tried on the following sites:

jonathanKingston commented 3 years ago

@GioSensation it looks like createAutofillContextMenuItem isn't gated on the user having a duck account yet.

jonathanKingston commented 3 years ago

Actually I notice that you create the context menu as visible: false I'm not sure why it would be visible without creating an account looking at the code.

jonathanKingston commented 3 years ago

@noahmaranesi my understanding is we're still in private beta: https://www.spreadprivacy.com/introducing-email-protection-beta/ the article at the bottom explains how to join the waitlist. I'm not sure how you're seeing the menu item without having an account but it seems like it's a bug.

jonathanKingston commented 3 years ago

I have my own "@duck.com" address and the aliases are working fine. I am however unable to do them in-line as advertised for on websites.

Oh wait I should read. Have you tried enabling it again by going to:

Dropdown > Settings Cog > "Email Protection" and clicking "Enable" then following the steps there?

noahmaranesi commented 3 years ago

@jonathanKingston yes that has been done too 😞

I done it again now (logged-out, and signed-in again) and Email Protection (DDG plugin icon → Settings (gear icon) → Settings) is showing as "Autofill enabled for myname@duck.com".

However the issue I had before has come back (it fixed itself after I updated Firefox to 92.0.1 from 92.0) where the right-click "Use Duck Address" button does not show at all.

(I was actually in the process of writing out an Issue for that, but the 92.0.1 update 'fixed' (?) that and I changed this Issue to be about Autofill not working)

I uninstalled the add-on, quit Firefox, reinstalled it, logged-in to the DDG plugin and the right-click "Use Duck Address" button is not showing.

GioSensation commented 3 years ago

@noahmaranesi Thanks for reporting this. FYI, we don't autofill login forms (because you can't login with randomly-generated private addresses, you have to create an account first). But you should see a Dax icon inline in signup forms like:

On the other hand, the contextual menu item in Firefox is currently not appearing. That is a bug and we'll fix it in an upcoming release. Thanks again for reporting.

noahmaranesi commented 3 years ago

we don't autofill login forms (because you can't login with randomly-generated private addresses, you have to create an account first)

Sorry about that, my bad haha 🤦🏻‍♂️🤦🏻‍♂️🤦🏻‍♂️