search

duckduckgo / duckduckgo-publisher

Generation of the static files of DuckDuckGo and its microsites.
Other
53 stars 43 forks source link

Double encoding in `duckpan publisher` #210

Closed jbarrett closed 8 years ago

jbarrett commented 8 years ago

Appears to effect donttrackus only

moollaza commented 8 years ago

The issue is likely inside https://github.com/duckduckgo/p5-app-duckpan. Specifically in https://github.com/duckduckgo/p5-app-duckpan/blob/master/lib/App/DuckPAN/WebPublisher.pm

There's some UTF8 code in place -- but it's likely incorrect: https://github.com/duckduckgo/p5-app-duckpan/blob/master/lib/App/DuckPAN/WebPublisher.pm#L93

/cc @zachthompson

moollaza commented 8 years ago

@jbarrett I just noticed that you mentioned it only affects 1 domain. That's odd...

jbarrett commented 8 years ago

Yeah, we have lots of weirdly specific Unicode handling all over the place. That line certainly looks suspect. Very weird indeed that it only effects one domain.

Decode incoming, encode outgoing. Anything else is a footnote[0]

[0] a long and winding footnote with many corners and caveats.