duckduckgo / iOS

DuckDuckGo iOS Application
https://itunes.apple.com/us/app/duckduckgo-privacy-browser/id663592361?mt=8
Apache License 2.0
1.79k stars 405 forks source link

Update to iOS 15 deployment target #3001

Closed samsymons closed 6 days ago

samsymons commented 1 week ago

Task/Issue URL: https://app.asana.com/0/414235014887631/1207384568093628/f Tech Design URL: CC:

Description:

This PR updates the app to use an iOS 15 deployment target.

I've intentionally avoided cleaning up availability checks to keep this PR small and simple, in case it needs to be reverted last-minute. After the change has been released and looks good, I'll clean up the availability checks.

Each target in the app had overridden the deployment target, so I removed those overrides in favour of having each target inherit the deployment target from the parent project settings. Now we only have to change one value to set the deployment target across the board.

Workflow Runs:

Steps to test this PR:

  1. Check the the deployment target on each target in the app is iOS 15
  2. Check that the app builds and runs fine, and that CI passes

Definition of Done (Internal Only):

Device Testing:

OS Testing:

Theme Testing:


Internal references:

Software Engineering Expectations Technical Design Template

bwaresiak commented 1 week ago

@samsymons Changes looks ok, maybe we should try running some flows (e2e tests, ad hoc build) from this branch?

samsymons commented 6 days ago

@bwaresiak I've updated the description to links of successful workflow runs. The remaining one I haven't tested is the Nightly Alpha workflow, but there's no good way to test it without publishing a real build to the alpha channel, and because the ad-hoc pipeline works (proving the ad-hoc target archives successfully) I feel it's acceptable.

bwaresiak commented 6 days ago

@samsymons yes that's great, thank you :)