duckduckgo / iOS

DuckDuckGo iOS Application
https://itunes.apple.com/us/app/duckduckgo-privacy-browser/id663592361?mt=8
Apache License 2.0
1.82k stars 414 forks source link

[DuckPlayer] - 3. URL management & FE comms #3007

Closed afterxleep closed 3 months ago

afterxleep commented 3 months ago

Task/Issue URL: https://app.asana.com/0/1204099484721401/1207658406526197/f

Description:

Steps to test this PR:

  1. Install custom privacy config from https://jsonblob.com/api/1253721903368888320

  2. Go to Settings and switch DuckPlayer to 'Ask mode'

  3. Go to a Youtube Video, and confirm the overlay shows up.

  4. Tap Watch in Duck Player (Might need to tap twice quickly due to an FE bug)

    • [x] Confirm video loads in DuckPlayer.
  5. Go back

    • [ ] Tap Watch here, and confirm video loads in DuckPlayer.
  6. Go to DuckPlayer settings and enable 'Always' mode

  7. Open a video or reload a video page if you have it open

    • [x] Confirm video loads in Duck Player
  8. While watching a video in Duck player, Hit 'reload'

    • [x] Confirm that the video still shows in Duck Player
    • [ ] Confirm you see the DuckPlayer icon in the URL bar when a video is playing in DP
    • [x] Confirm the URL says "Duck Player"
    • [x] Click the URL bar to select the text
    • [x] Confirm the text turns to a valid duck:// URL
  9. Enable Settings > Appearance > Show Full Site Address

    • [x] Go back to DuckPlayer and confirm the URL is now the full duck:// address
Bunn commented 3 months ago

1 Tap Watch here, and confirm video loads in DuckPlayer.

2 Confirm you see the DuckPlayer icon in the URL bar when a video is playing in DP