duckduckgo / iOS

DuckDuckGo iOS Application
https://itunes.apple.com/us/app/duckduckgo-privacy-browser/id663592361?mt=8
Apache License 2.0
1.82k stars 414 forks source link

New Tab Page layout and base elements #3008

Closed dus7 closed 3 months ago

dus7 commented 3 months ago

Task/Issue URL: https://app.asana.com/0/1206226850447395/1207685167967158/f Tech Design URL: CC:

Description:

Contains base layout and elements for New Tab Page Sections. Currently using mock data. Models and element actions will be added in later as part of New Tab Page sections project.

Steps to test this PR:

  1. Enable internal user flag and New Tab Page Sections via Debug menu
  2. New layout should be visible when new tab is opened
  3. When using regular horizontal size class (iPad / iPhone Max) grid should have 6 columns instead of 4

Definition of Done (Internal Only):

Orientation Testing:

Device Testing:

OS Testing:

Theme Testing:


Internal references:

Software Engineering Expectations Technical Design Template

github-actions[bot] commented 3 months ago
Warnings
:warning: PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by :no_entry_sign: dangerJS against ed581818a1dfe5d44c6cc019a7b548d7e4dea54d

dus7 commented 3 months ago

The gap between the bottom and customise button seems quite big, but maybe that's deliberate?

Yes, in fact it should be even bigger - there was a change on designs. I'll adjust that.