duckduckgo / iOS

DuckDuckGo iOS Application
https://itunes.apple.com/us/app/duckduckgo-privacy-browser/id663592361?mt=8
Apache License 2.0
1.79k stars 405 forks source link

Fire a pixel when removing the VPN configuration #3014

Closed samsymons closed 6 days ago

samsymons commented 1 week ago

Task/Issue URL: https://app.asana.com/0/414235014887631/1207698850203829/f Tech Design URL: CC:

Description:

This PR adds a pixel that reports when the VPN configuration has been removed, and why.

Steps to test this PR:

  1. Install the VPN and then sign out of Privacy Pro
  2. Check that you see a pixel in the logs, and that the configuration was removed
  3. Check the codebase to make sure we aren't calling removeFromPreferences() anywhere outside of the tunnel controller, to make sure there are no paths that aren't covered by the pixel
  4. Check that the removal reasons make sense

Definition of Done (Internal Only):

Copy Testing:

Orientation Testing:

Device Testing:

OS Testing:

Theme Testing:


Internal references:

Software Engineering Expectations Technical Design Template