Closed alessandroboron closed 6 days ago
:no_entry_sign: The Asana task linked in the PR description is not added to iOS App Board project.
bot: not in app board
label to retrigger the check.
Warnings | |
---|---|
:warning: | PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible. |
Generated by :no_entry_sign: dangerJS against b0fff436fa6fd168b91270b788b32596c2dff507
This is looking solid. The text animation doesn't look very much like typing, more like a fade in per character, but it works. Will let you wrangle that with design folk.
Good catch about the animation 💪! I fixed it. It was an opacity with a long duration set on the parent view. I removed it as it wasn’t needed and the characters don’t fade in.
Task/Issue URL: https://app.asana.com/0/1206329551987282/1207585462837399/f CC: @SabrinaTardio
Description:
This PR adds the text animation to the Dax Onboarding intro dialogs. I found the animation code in the macOS project and made changes to cater to the new requirements. E.g. On Android, in some dialogs we have to start animating the text upon an event and not when the view appears.
Steps to test this PR:
Scenario 1 - Intro Dax Dialog
Scenario 2 - Browsers Comparison Dax Dialog
Definition of Done (Internal Only):
Copy Testing:
’
rather than’
Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
—
Internal references:
Software Engineering Expectations Technical Design Template