improve bookmarks and favorites UI tests - Githubissues

duckduckgo / iOS

DuckDuckGo iOS Application

https://itunes.apple.com/us/app/duckduckgo-privacy-browser/id663592361?mt=8

Apache License 2.0

1.82k stars 414 forks source link

improve bookmarks and favorites UI tests #3019

Closed brindy closed 3 months ago

brindy commented 3 months ago

Task/Issue URL: https://app.asana.com/0/392891325557410/1207195241923822/f Tech Design URL: CC: @bwaresiak

Description: Fleshed out and tweaked bookmarks and favorites UI tests

Notes:

The scripts are being reviewed in https://github.com/duckduckgo/iOS/pull/3000 so you can largely ignore them.
You should be able to run the scripts from anywhere, just adjust the paths below accordingly
Fixes a bug found during testing in the bookmarks swift code

Steps to test this PR:

Confirm End to End tests have passed: https://github.com/duckduckgo/iOS/actions/runs/9750711656
In terminal cd into .maestro
Run setup_ui_tests.sh
Optional: run all the release tests in one go using: run_tests_tests.sh release_tests
Run run_ui_tests.sh release_tests/bookmarks.yaml
Run run_ui_tests.sh release_tests/bookmarks-multi.yaml
Run run_ui_tests.sh release_tests/favorites.yaml

github-actions[bot] commented 3 months ago

	Warnings
:warning:	PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by :no_entry_sign: dangerJS against 53bd61bbb53a5eda78c9d0463ec30247e56878d9