duckduckgo / iOS

DuckDuckGo iOS Application
https://itunes.apple.com/us/app/duckduckgo-privacy-browser/id663592361?mt=8
Apache License 2.0
1.79k stars 405 forks source link

Subscription refactoring #5 #3023

Closed federicocappelli closed 2 days ago

federicocappelli commented 5 days ago

Task/Issue URL: https://app.asana.com/0/1205842942115003/1206805455884775/f Tech Design URL: https://app.asana.com/0/1205842942115003/1207147511614062/f CC: @miasma13

Description:

This PR updates BSK from https://github.com/duckduckgo/BrowserServicesKit/pull/874 and contains all the needed refactoring for the Subscription classes inits. It also contains a new unit test class:

Complete tests will be implemented in follow-up tasks

Steps to test this PR: Subscription must work as usual, manual smoke test script available in this README

Definition of Done (Internal Only):

Device Testing:

OS Testing: