Onboarding Intro fix browser charts icons - Githubissues

duckduckgo / iOS

DuckDuckGo iOS Application

https://itunes.apple.com/us/app/duckduckgo-privacy-browser/id663592361?mt=8

Apache License 2.0

1.82k stars 414 forks source link

Onboarding Intro fix browser charts icons #3025

Closed alessandroboron closed 3 months ago

alessandroboron commented 3 months ago

Task/Issue URL: https://app.asana.com/0/1206329551987282/1207723831937945/f

Description:

This PR fixes the icons for the Browsers Comparison chart.

Screenshots After Fix Simulator Screenshot - iPhone 15 Pro - 2024-07-03 at 17 52 27

Simulator Screenshot - iPhone 15 Pro - 2024-07-03 at 17 52 49

Definition of Done (Internal Only):

[ ] Does this PR satisfy our Definition of Done?

Copy Testing:

[ ] Use of correct apostrophes in new copy, ie ’ rather than '

Orientation Testing:

[ ] Portrait
[ ] Landscape

Device Testing:

[ ] iPhone SE (1st Gen)
[ ] iPhone 8
[ ] iPhone X
[ ] iPhone 14 Pro
[ ] iPad

OS Testing:

[ ] iOS 15
[ ] iOS 16
[ ] iOS 17

Theme Testing:

[ ] Light theme
[ ] Dark theme

Internal references:

Software Engineering Expectations Technical Design Template

github-actions[bot] commented 3 months ago

:no_entry_sign: The Asana task linked in the PR description is not added to iOS App Board project.

Verify that the correct task is linked in the PR.
- :warning: Please use the actual implementation task, rather than the Code Review subtask.
Verify that the task is added to iOS App Board project.
When ready, remove the bot: not in app board label to retrigger the check.