duckduckgo / iOS

DuckDuckGo iOS Application
https://itunes.apple.com/us/app/duckduckgo-privacy-browser/id663592361?mt=8
Apache License 2.0
1.79k stars 405 forks source link

Onboarding Intro Localisation #3026

Open alessandroboron opened 5 days ago

alessandroboron commented 5 days ago

Task/Issue URL: https://app.asana.com/0/1206329551987282/1207585463623648/f

Description:

Adds Localisation for Onboarding Intro.

Steps to test this PR:

  1. Edit Scheme -> Options -> App Language -> Select a language we support
  2. Launch the app
  3. Tap the ⚙️ icon located on the Address bar right-hand side. (iPad tap … button first)
  4. Scroll to the bottom and select All Debug Options under Debug section.
  5. Scroll to the bottom and select Show New Onboarding Intro.

Definition of Done (Internal Only):

Copy Testing:

Orientation Testing:

Device Testing:

OS Testing:

Theme Testing:

Internal references:

Software Engineering Expectations Technical Design Template

github-actions[bot] commented 5 days ago

:no_entry_sign: The Asana task linked in the PR description is not added to iOS App Board project.

  1. Verify that the correct task is linked in the PR.
    • :warning: Please use the actual implementation task, rather than the Code Review subtask.
  2. Verify that the task is added to iOS App Board project.
  3. When ready, remove the bot: not in app board label to retrigger the check.
github-actions[bot] commented 5 days ago
Warnings
:warning: PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by :no_entry_sign: dangerJS against 5fb3540a1770cba896cbadb5a7098fc4474504dc