Tentative fix for a crash and connectivity issues - Githubissues

duckduckgo / iOS

DuckDuckGo iOS Application

https://itunes.apple.com/us/app/duckduckgo-privacy-browser/id663592361?mt=8

Apache License 2.0

1.82k stars 414 forks source link

Tentative fix for a crash and connectivity issues #3027

Closed diegoreymendez closed 3 months ago

diegoreymendez commented 3 months ago

Task/Issue URL: https://app.asana.com/0/0/1207717985731035/f

BSK PR: https://github.com/duckduckgo/BrowserServicesKit/pull/875 macOS PR: https://github.com/duckduckgo/macos-browser/pull/2933

What kind of version bump will this require?: Patch

Description

This PR tries to fix a VPN extension crash and some potential connectivity issues.

Testing:

Make sure the VPN starts and stops correctly.
Make sure the connection works after sleeping and waking the device.

Checklists

Definition of Done (Internal Only):

[ ] Does this PR satisfy our Definition of Done?

Copy Testing:

[ ] Use of correct apostrophes in new copy, ie ’ rather than '

Orientation Testing:

[ ] Portrait
[ ] Landscape

Device Testing:

[ ] iPhone SE (1st Gen)
[ ] iPhone 8
[ ] iPhone X
[ ] iPhone 14 Pro
[ ] iPad

OS Testing:

[ ] iOS 15
[ ] iOS 16
[ ] iOS 17

Theme Testing:

[ ] Light theme
[ ] Dark theme

Internal references:

Software Engineering Expectations Technical Design Template