duckduckgo / iOS

DuckDuckGo iOS Application
https://itunes.apple.com/us/app/duckduckgo-privacy-browser/id663592361?mt=8
Apache License 2.0
1.79k stars 405 forks source link

Onboarding intro lock user interface to portrait for iPhone #3029

Closed alessandroboron closed 4 days ago

alessandroboron commented 5 days ago

Task/Issue URL: https://app.asana.com/0/1206329551987282/1207723831937948/f

Description:

This PR locks the user interface to portrait for iPhone. For iPad, we still allow landscape user interface because it’s what the users expect.

Steps to test this PR:

Scenario 1 - iPhone

  1. Launch the App and show the onboarding flow.
  2. Rotate the device/simulator to landscape Expected Result: The user interface should not rotate to landscape.

Scenario 2 - iPad

  1. Launch the App and show the onboarding flow.
  2. Rotate the device/simulator to landscape Expected Result: The user interface should rotate to landscape.

Definition of Done (Internal Only):

Copy Testing:

Orientation Testing:

Device Testing:

OS Testing:

Theme Testing:


Internal references:

Software Engineering Expectations Technical Design Template

github-actions[bot] commented 5 days ago

:no_entry_sign: The Asana task linked in the PR description is not added to iOS App Board project.

  1. Verify that the correct task is linked in the PR.
    • :warning: Please use the actual implementation task, rather than the Code Review subtask.
  2. Verify that the task is added to iOS App Board project.
  3. When ready, remove the bot: not in app board label to retrigger the check.