duckduckgo / iOS

DuckDuckGo iOS Application
https://itunes.apple.com/us/app/duckduckgo-privacy-browser/id663592361?mt=8
Apache License 2.0
1.82k stars 414 forks source link

Fix issue when cancelling a download #3030

Closed Bunn closed 3 months ago

Bunn commented 3 months ago

Task/Issue URL: https://app.asana.com/0/414235014887631/1207722065639812/f

Description: Fix issue where the wrong item was being cancelled in the download list

Steps to test this PR:

  1. Open https://www.thinkbroadband.com/download
  2. Select multiple items to download
  3. Cancel the downloads and check if the correct ones in the list are being removed
  4. To make it easier, you can also change the line here to something like Text("\(UserText.cancelDownloadAlertDescription) \(row.id)") so you can see what item is being selected
federicocappelli commented 3 months ago

LGTM, tested cancelling 6 different downloads.

Unrelated note, the alert action when I try to remove the download seems VERY confusing to me! IMG_7664

They should be:

the Resume option makes no sense to me