duckduckgo / iOS

DuckDuckGo iOS Application
https://itunes.apple.com/us/app/duckduckgo-privacy-browser/id663592361?mt=8
Apache License 2.0
1.82k stars 414 forks source link

Remote Messaging Framework for macOS #3031

Closed ayoy closed 2 months ago

ayoy commented 3 months ago

Task/Issue URL: https://app.asana.com/0/72649045549333/1202913520695928/f CC: @amddg44 @samsymons

Description: This change adjusts RMF implementation to updates in BSK that add support for RMF on macOS.

Steps to test this PR:

  1. In RemoteMessagingClient.swift, update endpoint to return https://www.jsonblob.com/api/1258315611053613056 for debug builds.
  2. Delete the app from simulator/device to ensure app data is gone
  3. Run the app and complete onboarding.
  4. After the onboarding, open new tab page
  5. Verify that you see "Message 1: Placeholder Title" message.
  6. Don't dismiss the message and restart the app.
  7. Verify that you see "Message 1: Placeholder Title" message again. Dismiss the message and restart the app.
  8. Verify that you see "Message 2: Placeholder Title" message.
  9. Dismiss the message and restart the app 3 more times, verify that on each subsequent run you're seeing message 3, 4 and 5. After dismissing message 5 and restarting the app, no message should be shown.

Definition of Done (Internal Only):

Copy Testing:

Orientation Testing:

Device Testing:

OS Testing:

Theme Testing:


Internal references:

Software Engineering Expectations Technical Design Template

github-actions[bot] commented 3 months ago
Warnings
:warning: PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by :no_entry_sign: dangerJS against 1ef7733dc8a939571abed48b5c00a88c4ad530f1