Improve VPN logging logic - Githubissues

duckduckgo / iOS

DuckDuckGo iOS Application

https://itunes.apple.com/us/app/duckduckgo-privacy-browser/id663592361?mt=8

Apache License 2.0

1.79k stars 405 forks source link

Improve VPN logging logic #3032

Closed diegoreymendez closed 3 days ago

diegoreymendez commented 4 days ago

Task/Issue URL: https://app.asana.com/0/1206580121312550/1207223772590802/f

macOS PR: https://github.com/duckduckgo/macos-browser/pull/2939 BSK PR: https://github.com/duckduckgo/BrowserServicesKit/pull/877

Description

Improves the logging logic for the VPN.

Testing

Open Console.app and start streaming from your iPhone.
Filter by category:Network Protection.
Start the VPN
Open some sites
Change location
Stop the VPN

Make sure that the VPN works just fine, and that Console.app shows more detailed VPN logs.

Definition of Done (Internal Only):

[ ] Does this PR satisfy our Definition of Done?

Copy Testing:

[ ] Use of correct apostrophes in new copy, ie ’ rather than '

Orientation Testing:

[ ] Portrait
[ ] Landscape

Device Testing:

[ ] iPhone SE (1st Gen)
[ ] iPhone 8
[ ] iPhone X
[ ] iPhone 14 Pro
[ ] iPad

OS Testing:

[ ] iOS 15
[ ] iOS 16
[ ] iOS 17

Theme Testing:

[ ] Light theme
[ ] Dark theme

Internal references:

Software Engineering Expectations Technical Design Template

diegoreymendez commented 3 days ago

I'm going to redirect the iOS PR to main, since it's not as urgent.