duckduckgo / iOS

DuckDuckGo iOS Application
https://itunes.apple.com/us/app/duckduckgo-privacy-browser/id663592361?mt=8
Apache License 2.0
1.79k stars 405 forks source link

Update the Privacy Pro status attribute matcher #3033

Closed samsymons closed 4 days ago

samsymons commented 4 days ago

Task/Issue URL: https://app.asana.com/0/1199333091098016/1207731341550989/f Tech Design URL: CC:

Description:

This PR updates the Privacy Pro status attribute matcher to accept an array.

On the client side, it also makes it so that the active case no longer also targets expiring users. If we want to target both active and expiring users, we can do so by specifying multiple cases in the array.

Steps to test this PR:

  1. This attribute was originally reviewed in https://github.com/duckduckgo/iOS/pull/2949 and is covered by unit tests, just check that the changes make sense and that BSK tests have passed

Definition of Done (Internal Only):

Copy Testing:

Orientation Testing:

Device Testing:

OS Testing:

Theme Testing:


Internal references:

Software Engineering Expectations Technical Design Template