Closed SabrinaTardio closed 2 months ago
:no_entry_sign: The Asana task linked in the PR description is not added to iOS App Board project.
bot: not in app board
label to retrigger the check.
Warnings | |
---|---|
:warning: | PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible. |
Generated by :no_entry_sign: dangerJS against d2ca78422e89a166efe7c4f28675c0326e23b10d
As per MM conversation, there’s an issue with the typing animation. The box grows as the typing goes. We can look at adapting AnimatableTypingText with AttributedString. Having said that I think we should finish the functionality first and look at animations later.
As per MM conversation, there’s an issue with the typing animation. The box grows as the typing goes. We can look at adapting AnimatableTypingText with AttributedString. Having said that I think we should finish the functionality first and look at animations later.
I should have fixed it! but have not used the existing stuff when can always see later if we want to combine them.
Good job adapting AnimatableTypingText, it works very well! 👏
The views that show a list of suggestions need a VM, but we can add it in another PR when we have the provider ready.
On another note, there’s a conflict with the main feature branch DaxDialogIntroView
. I removed this file DaxDialogIntroView.swift
, so it shouldn’t be too bad to resolve it.
LGTM, very nice. Agree with @alessandroboron we need a view model though, but can follow up with that.
Yes, I agree too there will be a need for a view model but it didn’t make sense to add it now when it does not do anything yet
Task/Issue URL: https://app.asana.com/0/1204186595873227/1207736729379245/f
Description: Implements the Dialog we will use in the contextual onboarding cc. @alessandroboron
Steps to test this PR:
Definition of Done (Internal Only):
Copy Testing:
’
rather than'
Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations Technical Design Template