duckduckgo / iOS

DuckDuckGo iOS Application
https://itunes.apple.com/us/app/duckduckgo-privacy-browser/id663592361?mt=8
Apache License 2.0
1.79k stars 405 forks source link

Onboarding Intro - Remove Default Browser Screen #3044

Closed alessandroboron closed 9 hours ago

alessandroboron commented 3 days ago

Task/Issue URL: https://app.asana.com/0/1206329551987282/1207736844779818/f

Description:

This PR addresses BG8/.

Steps to test this PR:

  1. Launch new Intro Flow
  2. Wait for Intro Dialog to appear.
  3. Tap “Let’s do it!” button.
  4. Wait for Browser comparison to appear.
  5. Ensure that the view has two CTAs as per Figma Variant
  6. Ensure that tapping on "Switch Default Browser” calls setDefaultBrowserAction in OnboardingIntroViewModel (there are unit tests for this if you’re wondering :D) and the view is dismissed.
  7. Ensure that tapping on “Skip” calls cancelSetDefaultBrowserAction in OnboardingIntroViewModel` and the view is dismissed.

Definition of Done (Internal Only):

Copy Testing:

Orientation Testing:

Device Testing:

OS Testing:

Theme Testing:


Internal references:

Software Engineering Expectations Technical Design Template

github-actions[bot] commented 3 days ago

:no_entry_sign: The Asana task linked in the PR description is not added to iOS App Board project.

  1. Verify that the correct task is linked in the PR.
    • :warning: Please use the actual implementation task, rather than the Code Review subtask.
  2. Verify that the task is added to iOS App Board project.
  3. When ready, remove the bot: not in app board label to retrigger the check.